What makes a code review a good review?
Meanwhile, the quality of code reviews – even my own – can vary greatly depending on many factors: familiarity with the code, time of day, time of day, you name it. I’ve compiled thoughts and notes on code reviews from the last few years into a guide, which I published on our staff network documentation.
How to know if your code is good?
The only way to know if the best solution is being used is to understand the current solution. Other people may need to read this code. If you are having trouble understanding the code, it may need to be refactored, cleaned, or better commented. The more knowledge you have, the better your code and reviews will be!
What makes a good code review a nitpick?
Nitpicks are are unimportant comments, where the code could be merged without even addressing these. These could be things like variable declarations being in alphabetical order, unit tests following a certain structure, or brackets being on the same line. Good code reviews make it clear when changes are unimportant nitpicks.
Is it worth it to do live code review?
(As a side-note, pair programming can sometimes resemble a form of ‘live’ code review, where one person writes code and the other reviews it on the spot.) Though code review often means code takes a little longer to make it into production, many development teams say that it’s worth the time due to an overall increase in code quality.
What’s the best way to review temporary code?
Review temporary code as strictly as production code. It can be shocking just how often temporary “patch” code and workarounds make it into production, and how much of it is never actually replaced. This is just a reality of real-world programming.
When to do a code review in Perforce?
Ideally, after tests have passed, you’ll conduct a review and deploy it to the dev codeline. This ensures stability. And doing automated checks first will cut down on errors and save time in the review process.